Skip to content

Added compiler.warning_flags to platform.txt; fixing #6118 #6596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
May 9, 2022
Merged

Added compiler.warning_flags to platform.txt; fixing #6118 #6596

merged 36 commits into from
May 9, 2022

Conversation

PilnyTomas
Copy link
Contributor

Summary

Added compiler.warning_flags to all chips in platform.txt to reflect users setting of warning level output during compilation (set up in Arduino IDE preferences)

Impact

When a warning is set to none the compilation will no longer display warnings

Related links

Solves issue #6118

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022 •
edited
Loading

Unit Test Results

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit d68c66f.

♻️ This comment has been updated with latest results.

@mrengineer7777
Copy link
Collaborator

Why does this PR modify "cores/esp32/esp32-hal-i2c-slave.c" and "libraries/WiFiClientSecure/src/esp_crt_bundle.c"?

@PilnyTomas
Copy link
Contributor Author

Why does this PR modify "cores/esp32/esp32-hal-i2c-slave.c" and "libraries/WiFiClientSecure/src/esp_crt_bundle.c"?

With the new compiler settings, the previously hidden warnings are now treated as errors and the CI is failing. Following commits are simply satisfying the compiler/CI. The changes are mostly removing unused variables and such.

@mrengineer7777
Copy link
Collaborator

With the new compiler settings, the previously hidden warnings are now treated as errors and the CI is failing. Following commits are simply satisfying the compiler/CI. The changes are mostly removing unused variables and such.

Makes sense. I glanced over the code and don't see any obvious issues.

PilnyTomas added 18 commits April 21, 2022 18:24
@PilnyTomas
Wrapped tinyusb_interface_names in #if
1aaa72b
@PilnyTomas
Wrapped variable which is used only in log into #if
4b1f7ee
@PilnyTomas
Removed unused static function
7916004
@PilnyTomas
Fixed return variable init and expected value
06fdaa1
@PilnyTomas
Pointer dereference fix in example
5c67334
@PilnyTomas
Enumeration fix
ec3f189
@PilnyTomas
Added err log messages
80c7621
@PilnyTomas
Revert "Enumeration fix"
17763bd 
This reverts commit ec3f189.
@PilnyTomas
Changed data type in example
188fef7
@PilnyTomas
Removed unused variable from TouchButtonV2 example
5f2f2e9
@PilnyTomas
Wraped variables in #if; commented unused function
e228fb4
@PilnyTomas
Merge branch 'master' into compiler_flags_fix
fe91b7b
@PilnyTomas
Wraped variables in #if; commented unused function
8808b9d
@PilnyTomas
Fixed issues detected as warnings but treated as errors by CI
c7155cf
@PilnyTomas
Added empty default statement in switch
f3c39a6
@PilnyTomas
Wrapped conditionally used variables
821ee33
@PilnyTomas
More wrapping of conditionally used variables
a156a47
@PilnyTomas
Added forgotten colon after default statement
c04e00d
@VojtechBartoska
Copy link
Contributor

any updates on this @PilnyTomas?

@VojtechBartoska VojtechBartoska added this to the 2.0.4 milestone May 4, 2022
@me-no-dev
Copy link
Member

Thanks @PilnyTomas for your hard work :)

@me-no-dev me-no-dev merged commit ca77502 into espressif:master May 9, 2022
@me-no-dev me-no-dev mentioned this pull request May 9, 2022
Closed
1 task
@igrr igrr mentioned this pull request Jul 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PilnyTomas PilnyTomas

Labels
None yet
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@PilnyTomas @mrengineer7777 @VojtechBartoska @me-no-dev